Sync bundle row state and bundle detail state #4246
Conversation
|
Could you describe at a high-level what the fix was? |
|
@percyliang the worksheet view fetches basic bundle info on an interval in order to keep the rows up-to-date. The BundleDetail view also fetches basic bundle info on an interval (as well as more detailed information that the worksheet view doesn't need to fetch). The issue is that the fetching isn't synced, so the fix I implemented is to allow the worksheet to dictate what state to display in the bundle detail view if necessary. Note that I've updated some |
frontend/src/components/worksheets/items/TableItem/BundleRow.js
Outdated
Show resolved
Hide resolved
|
@percyliang refactored a bit. lmk if this works |
| } | ||
| return []; | ||
| } | ||
|
|
||
| showTime(time) { | ||
| return time && time !== '<none>' && time !== '0s'; |
There was a problem hiding this comment.
It seems like we should be able to access the raw value rather than the rendered one to avoid these rather brittle comparisons, so we could test whether time == null or something...
There was a problem hiding this comment.
will update the renderFormat helper to allow for this 👍
| * This enables the bundle row and the bundle detail sidebar to show the | ||
| * exact same state information. | ||
| */ | ||
| const syncBundleStateInfo = () => { |
There was a problem hiding this comment.
This only is called once, so why not just inline?
There was a problem hiding this comment.
I feel like wrapping the logic in a named function makes it easier to figure out for someone else who might stumble across the code later.
Reasons for making this change
The state shown in the bundle row is currently not synced with the state shown in the expanded bundle details. This change ensures that the bundle row and the expanded bundle details will always be in sync.
Related issues
#4174
Screenshots
Before (prod)
20220907142603545.mp4
After (local)
20220907142709524.mp4
Checklist